-
Notifications
You must be signed in to change notification settings - Fork 6
Extend content.get() to support include
param
#416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I wonder if the better UX is to simply do all of the includes all the time in |
That sounds reasonable to me and fits my specific use case perfectly. I simply followed the Connect API where they're all optional. |
@tdstein should I implement this change or do we need further discussion with others first? |
Go for it. It should be just modifying the request to include the query arguments. |
@tdstein Done. Note that CI cannot run integration tests from a fork due to security around secrets.
Locally I ran |
@cgraham-rs - since you are using a fork, you don't have access to the repository secrets. If you set the Alternatively, you can recreate the pull request as a branch off of main. Either should work.
I'm also seeing that. I'll address it in as a separate issue. |
@cgraham-rs - here is a fix for the integration test failures: #417 |
Closing in favor of non-fork PR: #420 |
Adds `include` param support for `content.get()` - Add the param support, opting to hardcode it so it is always used - Add unit test - Add integration test - Also manually verified by testing locally against a live Connect instance Replaces previous fork PR: #416
Adds
include
param support forcontent.get()