Add support for github refs when downloading Ark #7645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
lionel-
force-pushed
the
feature/ark-dev
branch
4 times, most recently
from
6cc8917 to
901b38b
Compare
jmcphers
previously approved these changes
Aug 7, 2025
There was a problem hiding this comment.
LGTM overall, worked great when I tried it out. A .ps.ark.version() shows that Positron picks up the freshly compiled version:
> .ps.ark.version()
branch
"main"
commit
"21f11d9c"
date
"2025-08-07 12:12:36 PDT"
flavor
"release"
path
"/Users/jmcphers/git2/positron/extensions/positron-r/resources/ark/ark"
version
"0.1.201"
|
|
||
| console.log('Building Ark from source...'); | ||
|
|
||
| const buildOutput = await executeCommand('cargo build --release', undefined, tempDir); |
There was a problem hiding this comment.
Since this is for development only, would the debug build be preferable?
There was a problem hiding this comment.
I thought so as well but: posit-dev/ark#619
By the way, when R crashes the only symptom surfacing from startLanguageRuntime() is an error about "http request failed". I assume this is from supervisor. https://github.com/posit-dev/positron/actions/runs/16799688806/job/47580232540#step:12:448
Starting language runtime failed. Reason: HTTP request failed
Would it be helpful to open an issue about this?
Log output Run Ark to check it's runnable Build for release
This reverts commit 901b38b.
lionel-
force-pushed
the
feature/ark-dev
branch
from
4a68677 to
0eaf579
Compare
lionel-
force-pushed
the
feature/ark-dev
branch
from
0eaf579 to
3615e4e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Written with the help of Claude as agent.
Adds support for specifying Ark versions as github refs in
package.json:The github revision is downloaded, built, and installed.
This allows CI-testing a branch in the Positron repo against a branch in the Ark repo without having to release Ark first. Releasing just for the purpose of testing is really not ideal as the feature might not be working well yet and other developers might need to do further Ark releases to make progress with their own work.
To prevent committing a dev ref that might have been forgotten in the
package.jsonfile, a github action watches changes to this file and checks that a release version is used.Release Notes
New Features
Bug Fixes
QA Notes