Skip to content

Conversation

hanno-becker
Copy link
Contributor

@hanno-becker hanno-becker commented Sep 20, 2025

This PR is a continuation of #1184, taking care of integration and testing.

  • (Required) @mkannwischer or @hanno-becker review assembly and confirm validity of arithmetic bounds assumed by the frontend.
    • Issue: InvNTT needs to move Montgomery scaling to the front to avoid overflow. @dannytsen
  • (Optional) Generate twiddles using autogen as done for the other backends
  • (Required) Understand exact architecture requirement: Is the code supported on Power8 or not?
  • (Required) Rebase atop Add backend unit tests #1187 so we get further confidence in correctness through random tests

@hanno-becker hanno-becker force-pushed the ppc64le_backend branch 3 times, most recently from 259a5a3 to 346cc92 Compare September 20, 2025 19:22
@hanno-becker hanno-becker marked this pull request as ready for review September 20, 2025 19:25
@hanno-becker hanno-becker requested a review from a team as a code owner September 20, 2025 19:25
dannytsen and others added 6 commits September 23, 2025 15:09
The supported native functions include:
1. MLK_USE_NATIVE_NTT (ntt_ppc.S)
2. MLK_USE_NATIVE_INTT (intt_ppc.S)
3. MLK_USE_NATIVE_POLY_REDUCE (reduce.S)
4. MLK_USE_NATIVE_POLY_TOMONT (poly_tomont.S)

And other interface functions and headers.

Signed-off-by: Danny Tsen <dtsen@us.ibm.com>
This commit prepares scripts/autogen and scripts/cfify for
the work-in-progress addition of riscv64 and ppc64le backends.
Specifically, simpasm needs to be invoked with the right cross
compiler for those architectures, and scripts/cfify needs to accept
riscv64 and ppc64le architecture parameters.

Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
@dannytsen
Copy link

@hanno-becker Will take a look.

@hanno-becker hanno-becker added ppc64le enhancement New feature or request labels Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants