Skip to content

Conversation

hanno-becker
Copy link
Contributor

@hanno-becker hanno-becker commented Oct 6, 2025

Previously, the HOL-Light proof scripts contained various hardcoded constants related to the length of the code under proof, as well as the lengths of preamble and postamble (stack spill and restore).

This commit replaces those hardcoded numerals with symbolic definitions. As a result, SLOTHY re-optimization should now no longer require a proof script change beyond the update of the byte code which is done by autogen already.

@hanno-becker hanno-becker force-pushed the hol_light_length_constants branch from 04017cc to 019df9b Compare October 6, 2025 10:15
@hanno-becker hanno-becker added enhancement New feature or request hol-light labels Oct 6, 2025
@hanno-becker hanno-becker force-pushed the hol_light_length_constants branch 2 times, most recently from 307fc69 to 904ca71 Compare October 6, 2025 10:56
Previously, the HOL-Light proof scripts contained various hardcoded
constants related to the length of the code under proof, as well as
the lengths of preamble and postamble (stack spill and restore).

This commit replaces those hardcoded numerals with symbolic definitions.
As a result, SLOTHY re-optimization should now no longer require a proof
script change beyond the update of the byte code which is done by `autogen`
already.

Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
@hanno-becker hanno-becker force-pushed the hol_light_length_constants branch from 904ca71 to 1d74842 Compare October 6, 2025 12:13
@hanno-becker hanno-becker marked this pull request as ready for review October 6, 2025 12:43
@hanno-becker hanno-becker requested a review from a team as a code owner October 6, 2025 12:43
Copy link
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hanno-becker! Very welcome improvement!

@hanno-becker hanno-becker merged commit 9ff878f into main Oct 7, 2025
395 checks passed
@hanno-becker hanno-becker deleted the hol_light_length_constants branch October 7, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request hol-light

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HOL-Light: Remove hardcoded PC offsets

2 participants