-
Notifications
You must be signed in to change notification settings - Fork 367
Added SDL3 Checks To Imgui To Fix Clipboard And Typing #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hey @aardv4rk, I looked at the code changes. Currently this won't compile for monogame users. (Nez.MG38.ImGui.csproj)
I think it may be possible to get rid of _isSdl3-Attribute all together. |
@stallratte Good call. I've actually just now I managed to test the SDL2 implementation using Regarding the FNA preprocessor directives; I've not had experience with Monogame in some time. Does the whole SDL3 thing not exist over there? If so, I can wrap the crux of the fix in CheckForTextInput in an FNA preprocessor directive so it's just an empty method for Monogame. |
- moved UpdateTextInput to sEtup & Update region - removed isSdl3 bool - Wrapped UpdateTextInput contents in FNA directive
@stallratte Makes sense! |
@aardv4rk I think your changes are really good now. |
Thank you for the help with this! |
Small PR that adds a few try/catches to swap SDL2 calls with SDL3 for developers on newer FNA since the full swap to SDL3, whilst retaining original functionality.
This in specific addresses an issue with typing, as SDL3 changed the default behaviour to turn on/off typing, in addition fixing the clipboard to use the proper SDL methods.