Flash-Attn-2 Compatibility & Loss NaN #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi maintainers of Sheared Llama, thank you for your brilliant work! I'm using this repo for my own research and I modified some parts to make if work on my machine. I'm making a PR here to see if my modifications can benefit other researchers.
What does this PR do?
This PR tries to address 2 problems:
LanguageCrossEntropybecomes NaN becomes the number of samples in some domains is too small or even 0. Therefore, this PR checks if number of samples of 0 before doing the division, which solves the NaN issue.