Skip to content

Resolved Issue with Image Overlapping on Processing.org Examples Page #514 #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Resolved Issue with Image Overlapping on Processing.org Examples Page #514 #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/character/Donate.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.root {
position: fixed;
top: 130px;
right: var(--margin);
right: calc(var(--margin) - 1cm);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

centimeters have not been used yet in the codebase, please use some of the constants in the variables.css

width: var(--col1);
float: right;
text-align: center;
Expand Down
3 changes: 2 additions & 1 deletion src/components/examples/ExamplesList.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@
}

.item {
flex-basis: calc(100% / 5);
flex: 0 0 calc(25% - 2 * var(--gutter));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works, could you research if you could scale the container element instead?

max-width: calc(25% - 2 * var(--gutter));

& h4 {
font-size: var(--text-regular);
Expand Down