Support "graphql-transport-ws" websocket subprotocol #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to support server impl
|
@jenskdsgn thanks for the contribution could you by chance write some unit tests for |
|
Yeah I can try 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a project, where the server only accepts the
graphql-transport-wsprotocol, I would like to add the option to define a specific protocol behavior.What kind of change does this PR introduce?
Feature
What is the current behavior?
Only graphql-ws subprotocol is supported
What is the new behavior?
graphql-ws is still the default protocol, but it can be configured to use "graphql-transport-ws" as well.
Does this PR introduce a breaking change?
No
Other information
The practical difference here between the protocols is only the command structure of the init command, which only affects the name of the type. ws-graphql names is start, graphql-transport-ws calls is subscription 🤷♂️
The risk of this PR is relatively low, but it makes the library backwards compatible with older implementations which is a good thing to have I guess.
Sorry for now writing tests, I am not that proficient in python, so I would appreciate a little help here.
Thanks