[Release v3.30] Add delete permission to tigera operator for ANP/BANP CRDs #10552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lico#10543) * Add delete permission to tigera operator for ANP/BANP CRDs * Apply suggestions from code review Co-authored-by: Casey Davenport <caseydavenport@users.noreply.github.com> * markup --------- Co-authored-by: Casey Davenport <caseydavenport@users.noreply.github.com>
mazdakn
added
release-note-required
|
@mazdakn I thought we chatted in Slack and decided that deleting the ANP CRD was a problem? It's going to delete any AdminNetworkPolicy objects as part of it, which means that assuming ownership of the CRD is going to delete all the users policies 😬 |
mazdakn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add delete permission to tigera operator for ANP/BANP CRDs to allow ownership claim during migration from other CNIs. This fixes tigera/operator#3893
Pick of #10543
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.