Skip to content

fix: persist default settings #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: persist default settings #444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,15 +102,18 @@ async function checkResultAndReturnUrl(

export async function openBrowserAsync(
url: string,
options?: InAppBrowserOptions = {
options?: InAppBrowserOptions = {}
): Promise<BrowserResult> {
const defaults = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello mate, thanks for your contribution!
Can you move the default settings outside this method please? and can you include the type InAppBrowserOptions for that new variable?

animated: true,
modalEnabled: true,
dismissButtonStyle: 'close',
readerMode: false,
enableBarCollapsing: false,
}
): Promise<BrowserResult> {
};

return RNInAppBrowser.open({
...defaults,
...options,
url,
preferredBarTintColor:
Expand Down