🐛 allow creating vexlink devices on empty ports #763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KdotDevelopment
approved these changes
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
See title.
Motivation:
Only the highest port radio is detected as a radio by the brain, and lower port radios are not detected, until the highest port radio disconnects, or it is configured as a vexlink device. Empty ports can be configured as vexlink ports just fine, they will just always report status as disconnected, unless a radio is plugged into the port, after which it behaves as expected of a vexlink radio. Thus, allowing creation of vexlink devices on ports with no device detected is perfectly fine.
References (optional):
#620
Test Plan: