Skip to content

Update README.md with correct import of log #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

osfameron
Copy link

Clarify where to get log from, as it's non-obvious (and the linked test-case doesn't provide an example of it.)

Clarify where to get `log` from, as it's non-obvious (and the linked test-case doesn't provide an example of it.)
@thomashoneyman
Copy link
Contributor

At the moment the entire README is written without imports -- even some of the functions are made up, like loadFile, to illustrate the point without necessarily being runnable code. #61 is a separate discussion of this issue.

We're in the midst of polishing up all the Contributors libraries, including the README files and documentation, and we'll keep in mind that several folks have found the lack of imports confusing. However, I'm going to close this just because the rest of the README will still need fixing and we're about to do an overhaul of the content anyway.

Still, thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants