Skip to content

Pipeline Job Get SCM Element Bug Fix #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Pipeline Job Get SCM Element Bug Fix #892

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
67247c2
Pipeline SCM Element Get Bug Fix
Sai-Raveendra-Kandregula Jan 22, 2025
34466fb
Updated Alternate SCM elements search logic
Sai-Raveendra-Kandregula Apr 24, 2025
8bf5c1e
Added Pipeline SCM Test
Sai-Raveendra-Kandregula Apr 24, 2025
23e0052
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 24, 2025
bb5bf46
Updated Pipeline SCM Testcase
Sai-Raveendra-Kandregula Apr 24, 2025
6f4a6a6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 24, 2025
cbdb45e
Updated Pipeline SCM Conf
Sai-Raveendra-Kandregula Apr 24, 2025
76661b5
Updated Pipeline SCM Conf
Sai-Raveendra-Kandregula Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions jenkinsapi/job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,13 @@ def get_scm_type(self):
if scm_element:
# multibranch pipeline.
self._scm_prefix = multibranch_scm_prefix
if not scm_element:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we change this to be an else for line 539?
Would you add test coverage for this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clintonsteiner, I have updated the alternate scm_element fetch mechanism. Please check. As per the test coverage, I have added the test case for the change, but it seems like the Jenkins instance used in the tests does not have the Pipeline suite. Please advise on how to proceed.

pipeline_scm_prefix = "definition/"
_pipeline_scm_path = pipeline_scm_prefix + "scm"
scm_element = element_tree.find(_pipeline_scm_path)
if scm_element:
# standard pipeline.
self._scm_prefix = pipeline_scm_prefix
scm_class = scm_element.get("class") if scm_element else None
scm = self._scm_map.get(scm_class)
if not scm:
Expand Down
Loading