Skip to content

Fix duplicated rows #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix duplicated rows #858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5fa28a8
Deduplicate rows with the same index
changlan Feb 16, 2021
87bc3f8
reformat by black
changlan Feb 16, 2021
1a551dc
Update change log
changlan Feb 16, 2021
5eee8c3
fix comment line length
Apr 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docs/source/whatsnew/v0.9.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,15 @@ Enhancements
from every trading board (ver. 0.9.0 behaviour)
- Docs for MOEX reedited

.. _whatsnew_080.bug_fixes:
.. _whatsnew_091.bug_fixes:

Bug Fixes
~~~~~~~~~

- Fixed broken links on the github ussies on "What’s New" docs pages
- Deduplicate rows with the same index (:issue:`610`) (:issue:`738`)

Contributors
~~~~~~~~~~~~
- Dmitry Alekseev
- Dmitry Alekseev
- Chang Lan
8 changes: 6 additions & 2 deletions pandas_datareader/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def _sanitize_response(response):
return response.content

def _get_response(self, url, params=None, headers=None):
""" send raw HTTP request to get requests.Response from the specified url
"""send raw HTTP request to get requests.Response from the specified url
Parameters
----------
url : str
Expand Down Expand Up @@ -265,7 +265,11 @@ def _dl_mult_symbols(self, symbols):
for sym_group in _in_chunks(symbols, self.chunksize):
for sym in sym_group:
try:
stocks[sym] = self._read_one_data(self.url, self._get_params(sym))
df = self._read_one_data(self.url, self._get_params(sym))
# Keep the last item if there are duplicated rows with
# the same index.
df = df[~df.index.duplicated(keep="last")]
stocks[sym] = df
passed.append(sym)
except (IOError, KeyError):
msg = "Failed to read symbol: {0!r}, replacing with NaN."
Expand Down