-
Notifications
You must be signed in to change notification settings - Fork 3.9k
make clamp range of PowerMeanAggregation
adjustable
#10366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KaneGreen
wants to merge
7
commits into
pyg-team:master
Choose a base branch
from
KaneGreen:PowerMeanPatch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add two args when class init to allow users to set their own `clamp` function range. 2. Change the default lower bound of `clamp` function from 0 to 0.0001. This is because the value of 0 can easily cause p to become NaN after several forwards.
PowerMeanAggregation
adjustable
for more information, see https://pre-commit.ci
rusty1s
approved these changes
Jul 17, 2025
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10366 +/- ##
==========================================
- Coverage 86.11% 85.71% -0.40%
==========================================
Files 496 501 +5
Lines 33655 34456 +801
==========================================
+ Hits 28981 29534 +553
- Misses 4674 4922 +248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Some checks failed. Is there anything I need to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clamp
function range.clamp
function from0
to0.0001
. This is because the value of0
can easily causep
to becomeNaN
after several forwards whenlearn=True
.