Skip to content

make clamp range of PowerMeanAggregation adjustable #10366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

KaneGreen
Copy link

@KaneGreen KaneGreen commented Jul 15, 2025

  1. Add two args when class init to allow users to set their own clamp function range.
  2. Change the default lower bound of clamp function from 0 to 0.0001. This is because the value of 0 can easily cause p to become NaN after several forwards when learn=True.

1. Add two args when class init to allow users to set their own `clamp` function range.
2. Change the default lower bound of `clamp` function from 0 to 0.0001. This is because the value of 0 can easily cause p to become NaN after several forwards.
@KaneGreen KaneGreen requested a review from EdisonLeeeee as a code owner July 15, 2025 01:22
@KaneGreen KaneGreen changed the title make clamp range of PowerMeanAggregation adjustable make clamp range of PowerMeanAggregation adjustable Jul 15, 2025
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.71%. Comparing base (c211214) to head (a4a8f40).
Report is 71 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10366      +/-   ##
==========================================
- Coverage   86.11%   85.71%   -0.40%     
==========================================
  Files         496      501       +5     
  Lines       33655    34456     +801     
==========================================
+ Hits        28981    29534     +553     
- Misses       4674     4922     +248     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rusty1s rusty1s enabled auto-merge (squash) July 17, 2025 08:29
@KaneGreen
Copy link
Author

Some checks failed. Is there anything I need to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants