Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ptr
andindex
are both provided intorch_geometric.utils.softmax
, useindex
to set theoutput_size
intorch.repeat_interleave
test/utils/test_softmax.py
, add a line that testssoftmax(src, ptr=ptr, index=index)
If the
output_size
argument is not provided intorch.repeat_interleave
, then the output size is calculated on the fly, at the cost of a stream synchronization, see https://docs.pytorch.org/docs/stable/generated/torch.repeat_interleave.html. But if thetorch_geometric.utils.softmax
function gets theindex
argument in addition toptr
, we getoutput_size
for free. So we should use it.