-
Notifications
You must be signed in to change notification settings - Fork 4
Difference between shutdown(wait=True) and shutdown(wait=False) #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Good simplification! Note the breaking change.
The simplified logic for determining
terminate_function
is cleaner and more maintainable. The function selection now depends solely on theexecute_function
type rather than multiple conditional flags.This removal of the
terminate_tasks_on_shutdown
parameter constitutes a breaking change for any external code that was using this parameter.🏁 Script executed:
Length of output: 521
🏁 Script executed:
Length of output: 1549
Breaking Change: Remove
terminate_tasks_on_shutdown
ReferencesThe new
create_file_executor
no longer accepts or propagates aterminate_tasks_on_shutdown
parameter, but several executors and tests still reference it. Please update or clean up these callers to match the simplified API:• executorlib/executor/slurm.py
terminate_tasks_on_shutdown: bool = True
parameter from the SlurmExecutor signature and any internal references.• executorlib/executor/flux.py
terminate_tasks_on_shutdown: bool = True
parameter from the FluxExecutor signature and any internal references.• tests/test_fluxclusterexecutor.py
terminate_tasks_on_shutdown=
arguments passed when instantiating executors.Fix these to align with the new
create_file_executor
signature or reintroduce a no-op parameter if backward compatibility is required.🤖 Prompt for AI Agents