write files when submitted function fails #734

jan-janssen · 2025-07-15T12:52:25Z

No description provided.

for more information, see https://pre-commit.ci

coderabbitai · 2025-07-15T12:52:31Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-07-15T12:54:36Z

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.59%. Comparing base (a807fd9) to head (eb85ed1).

Files with missing lines	Patch %	Lines
executorlib/standalone/error.py	37.50%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #734      +/-   ##
==========================================
- Coverage   96.92%   96.59%   -0.33%     
==========================================
  Files          30       31       +1     
  Lines        1364     1381      +17     
==========================================
+ Hits         1322     1334      +12     
- Misses         42       47       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…or_file # Conflicts: # executorlib/backend/cache_parallel.py # executorlib/backend/interactive_parallel.py # executorlib/task_scheduler/file/backend.py

for more information, see https://pre-commit.ci

…or_file # Conflicts: # executorlib/backend/interactive_parallel.py

for more information, see https://pre-commit.ci

…or_file

for more information, see https://pre-commit.ci

# Conflicts: # executorlib/executor/flux.py # executorlib/executor/slurm.py # executorlib/task_scheduler/file/task_scheduler.py

# Conflicts: # executorlib/executor/flux.py # executorlib/executor/slurm.py

jan-janssen and others added 2 commits July 15, 2025 14:51

write files when submitted function fails

0f05d9c

[pre-commit.ci] auto fixes from pre-commit.com hooks

54211e1

for more information, see https://pre-commit.ci

jan-janssen linked an issue Jul 15, 2025 that may be closed by this pull request

[Documentation] Write error to file for debugging #729

Closed

jan-janssen marked this pull request as draft July 15, 2025 12:52

jan-janssen and others added 24 commits July 15, 2025 15:04

get information from input_dict

174c1f6

Merge remote-tracking branch 'origin/write_error_file' into write_err…

1da66eb

…or_file # Conflicts: # executorlib/backend/cache_parallel.py # executorlib/backend/interactive_parallel.py # executorlib/task_scheduler/file/backend.py

Format black

4b4e7e5

[pre-commit.ci] auto fixes from pre-commit.com hooks

5b49d66

for more information, see https://pre-commit.ci

write either error.output or error

2b7fb92

Merge remote-tracking branch 'origin/write_error_file' into write_err…

ee2e6dd

…or_file # Conflicts: # executorlib/backend/interactive_parallel.py

Format black

5bd926c

write exception as string

4f51280

shared function

0f1e8d3

[pre-commit.ci] auto fixes from pre-commit.com hooks

a5f05a5

for more information, see https://pre-commit.ci

move function

87000cf

Format black

f2a3abf

bug fix

cf1fef7

Merge remote-tracking branch 'origin/write_error_file' into write_err…

8c15eb5

…or_file

check error file is written

e6f7605

[pre-commit.ci] auto fixes from pre-commit.com hooks

481ba85

for more information, see https://pre-commit.ci

clean up

f6e90d9

Add more details in log

d67055a

[pre-commit.ci] auto fixes from pre-commit.com hooks

ac9ceea

for more information, see https://pre-commit.ci

fix formatting

db57726

fix info tests

f37eea1

set write_error_file in resource_dict

e9ed692

Merge remote-tracking branch 'origin/main' into write_error_file

0696ef3

# Conflicts: # executorlib/executor/flux.py # executorlib/executor/slurm.py # executorlib/task_scheduler/file/task_scheduler.py

fix test

da0f1d8

jan-janssen added 4 commits July 16, 2025 17:05

Merge remote-tracking branch 'origin/main' into write_error_file

985851d

# Conflicts: # executorlib/executor/flux.py # executorlib/executor/slurm.py

fix file location

db24c95

Drop Python 3.9

c8500a3

extend tests

eb85ed1

jan-janssen closed this Jul 16, 2025

jan-janssen deleted the write_error_file branch July 16, 2025 18:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

write files when submitted function fails #734

write files when submitted function fails #734

Uh oh!

jan-janssen commented Jul 15, 2025

Uh oh!

coderabbitai bot commented Jul 15, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Jul 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

write files when submitted function fails #734

write files when submitted function fails #734

Uh oh!

Conversation

jan-janssen commented Jul 15, 2025

Uh oh!

coderabbitai bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

coderabbitai bot commented Jul 15, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Jul 15, 2025 •

edited

Loading