remove unused parameter terminate_tasks_on_shutdown

[jan-janssen]

Summary by CodeRabbit

• Refactor

  • Removed the terminate_tasks_on_shutdown parameter from configuration options in relevant executors.

• Tests

  • Updated tests to reflect the removal of the terminate_tasks_on_shutdown parameter.

[coderabbitai]

Walkthrough

The terminate_tasks_on_shutdown parameter has been removed from the constructors of FluxClusterExecutor, SlurmClusterExecutor, and SlurmJobExecutor, as well as from related test cases. No other logic or functionality was altered in these classes or tests.

Changes

File(s)	Change Summary
executorlib/executor/flux.py	Removed terminate_tasks_on_shutdown parameter from FluxClusterExecutor constructor.
executorlib/executor/slurm.py	Removed terminate_tasks_on_shutdown from SlurmClusterExecutor and SlurmJobExecutor constructors.
tests/test_fluxclusterexecutor.py, tests/test_slurmclusterexecutor.py	Removed usage of terminate_tasks_on_shutdown argument in relevant test cases.

Possibly related PRs

• Difference between shutdown(wait=True) and shutdown(wait=False) #721: Removes the terminate_tasks_on_shutdown parameter and related logic from the same executor classes and files.
• Upgrade terminate function #715: Adds the terminate_tasks_on_shutdown parameter to the FluxClusterExecutor constructor, which this PR now removes.

Suggested reviewers

• liamhuber

Poem

A rabbit hopped through code so neat,
Removing flags both obsolete and fleet.
Executors now, with lighter load,
Bound down a simpler, cleaner road.
Tests still pass—no tasks to end,
Just streamlined code from end to end! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 09ae798 and d3e9c63.

📒 Files selected for processing (4)

• executorlib/executor/flux.py (0 hunks)
• executorlib/executor/slurm.py (0 hunks)
• tests/test_fluxclusterexecutor.py (0 hunks)
• tests/test_slurmclusterexecutor.py (0 hunks)

💤 Files with no reviewable changes (4)

• tests/test_fluxclusterexecutor.py
• tests/test_slurmclusterexecutor.py
• executorlib/executor/flux.py
• executorlib/executor/slurm.py

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.92%. Comparing base (09ae798) to head (d3e9c63).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #735   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files          30       30           
  Lines        1364     1364           
=======================================
  Hits         1322     1322           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.