Skip to content

[maintenance] Drop the brain for nose, filter warning on tests for old style namespace packages #2765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2025
Merged

[maintenance] Drop the brain for nose, filter warning on tests for old style namespace packages #2765

merged 2 commits into from
Jun 27, 2025

Conversation

Pierre-Sassoulas
Copy link
Member

Description

The faster way to fix the pipeline.

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Jun 11, 2025
@DanielNoord
Copy link
Collaborator

Pipeline still fails 😄

What's the error we're fixing?

@Pierre-Sassoulas
Copy link
Member Author 

 ERROR tests/brain/test_nose.py - UserWarning: pkg_resources is deprecated as an API. 
See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package
 is slated for removal as early as 2025-11-30. Refrain from using this package or pin to 
Setuptools<81.

Seen here: #2763

@DanielNoord
Copy link
Collaborator

@Pierre-Sassoulas I would be okay with removing a brain for a package that has not had a release since 2015. nose is no longer actively maintained and rarely used, I believe. See also https://github.com/nose-devs/nose

@Pierre-Sassoulas
Copy link
Member Author

Right, supporting nose but not pydantic, is a little backward

@Pierre-Sassoulas Pierre-Sassoulas added this to the 4.0.0 milestone Jun 11, 2025
@Pierre-Sassoulas Pierre-Sassoulas changed the title [packaging] Temporarily limit setuptools to < 81 [maintenance] Drop the brain for nose Jun 11, 2025
Pierre-Sassoulas
Pierre-Sassoulas commented Jun 11, 2025
View reviewed changes
DanielNoord
DanielNoord previously approved these changes Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your suggestion for the changelog, rest LGTM!

@Pierre-Sassoulas Pierre-Sassoulas changed the title [maintenance] Drop the brain for nose [maintenance] Drop the brain for nose, skip test for old style package under python 3.14 Jun 27, 2025
@Pierre-Sassoulas Pierre-Sassoulas changed the title [maintenance] Drop the brain for nose, skip test for old style package under python 3.14 [maintenance] Drop the brain for nose, skip test for old style namespace packages under python 3.14 Jun 27, 2025
@Pierre-Sassoulas Pierre-Sassoulas changed the title [maintenance] Drop the brain for nose, skip test for old style namespace packages under python 3.14 [maintenance] Drop the brain for nose, skip tests for old style namespace packages under python 3.12 or pypy Jun 27, 2025
@Pierre-Sassoulas Pierre-Sassoulas changed the title [maintenance] Drop the brain for nose, skip tests for old style namespace packages under python 3.12 or pypy [maintenance] Drop the brain for nose, remove tests for old style namespace packages Jun 27, 2025
@Pierre-Sassoulas
Copy link
Member Author

The test was introduced in #1536, it seems the warning is raised from the analysed code and not the astroid code.

@codecov Codecov
Copy link

codecov bot commented Jun 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.29%. Comparing base (580d17c) to head (c77eb50).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2765      +/-   ##
==========================================
- Coverage   93.30%   93.29%   -0.02%     
==========================================
  Files          93       92       -1     
  Lines       11090    11049      -41     
==========================================
- Hits        10348    10308      -40     
+ Misses        742      741       -1
Flag Coverage Δ
linux 93.16% <ø> (-0.01%) ⬇️
pypy 93.29% <ø> (-0.02%) ⬇️
windows 93.27% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
astroid/brain/helpers.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Pierre-Sassoulas
Filter warnings for the test for old namespace package based on pkg_r…
c77eb50 
…esource

It won't work when the package is removed but let's keep it for now
@Pierre-Sassoulas Pierre-Sassoulas changed the title [maintenance] Drop the brain for nose, remove tests for old style namespace packages [maintenance] Drop the brain for nose, filter warning on tests for old style namespace packages Jun 27, 2025
@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (rebase) June 27, 2025 07:46
@Pierre-Sassoulas Pierre-Sassoulas merged commit b2a5822 into main Jun 27, 2025
20 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the fix-setuptools branch June 27, 2025 11:05
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Jun 28, 2025
Closed
@jacobtylerwalls jacobtylerwalls mentioned this pull request Jul 27, 2025
Merged
cdce8p added a commit to cdce8p/astroid that referenced this pull request Sep 4, 2025
@cdce8p @Pierre-Sassoulas
[Backport maintenance/3.3.x] Partial backport of (pylint-dev#2765)
a29b374 
* Remove nose test dependency
* Filter warnings for the test for old namespace package based on pkg_resource

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
@cdce8p cdce8p mentioned this pull request Sep 4, 2025
Merged
cdce8p added a commit that referenced this pull request Sep 4, 2025
@cdce8p @Pierre-Sassoulas
[Backport maintenance/3.3.x] Partial backport of (#2765) (#2815)
9d6ee30 
* Remove nose test dependency
* Filter warnings for the test for old namespace package based on pkg_resource

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
Documentation 📗 Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Pierre-Sassoulas @DanielNoord