Skip to content

Conversation

Pierre-Sassoulas
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas commented Mar 24, 2025

The error was the following:

configuration error: `project.license` must be valid exactly by one definition (2 matches found):

    - keys:
        'file': {type: string}
      required: ['file']
    - keys:
        'text': {type: string}
      required: ['text']

We choose the text metadata so we don't have to worry about little discrepancies in the License text and we can remove the license.

Type of Changes

Type
🔨 Refactoring
📜 Docs

Description

Refs #9475
Follow-up to #10292

@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry backport maintenance/3.3.x labels Mar 24, 2025
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.3.7 milestone Mar 24, 2025
@Pierre-Sassoulas Pierre-Sassoulas requested a review from cdce8p March 24, 2025 20:30
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (9a6168d) to head (0c2740e).
Report is 98 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10308   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files         175      175           
  Lines       19082    19082           
=======================================
  Hits        18299    18299           
  Misses        783      783           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This comment has been minimized.

Copy link
Contributor

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit b087cbc

@Pierre-Sassoulas Pierre-Sassoulas changed the title [packaging] Fix multiple definitions for LICENSE in metadata Fix tox docs by setting setuptools > 77 and adding contributors aliases Mar 25, 2025
@Pierre-Sassoulas
Copy link
Member Author

Sorry for bothering you with a review request @cdce8p this was not about setuptools metadata after all, just had to upgrade the version.

@cdce8p
Copy link
Member

cdce8p commented Mar 25, 2025

Sorry for bothering you with a review request @cdce8p this was not about setuptools metadata after all, just had to upgrade the version.

Not a problem. I did see the PR but haven't had time to respond yesterday.
Do we need to fix that in astroid too?

@Pierre-Sassoulas
Copy link
Member Author

Yeah probably, I'll check astroid, thank you :)

@Pierre-Sassoulas Pierre-Sassoulas merged commit cdefbee into main Mar 25, 2025
38 of 39 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the fix-setuptools-v2 branch March 25, 2025 15:44
Copy link
Contributor

The backport to maintenance/3.3.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/3.3.x maintenance/3.3.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/3.3.x
# Create a new branch
git switch --create backport-10308-to-maintenance/3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cdefbee378cd4cb54729fc7d2efc352aab319a09
# Push it to GitHub
git push --set-upstream origin backport-10308-to-maintenance/3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/3.3.x

Then, create a pull request where the base branch is maintenance/3.3.x and the compare/head branch is backport-10308-to-maintenance/3.3.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport maintenance/3.3.x Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants