-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[fix] AttributeError crash when a slice is used as a class decorator #10350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cdce8p
merged 10 commits into
pylint-dev:main
from
Pierre-Sassoulas:codegen-bot/fix-slice-decorator-crash
May 1, 2025
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7178c5b
Fix #10334: AttributeError when a slice is used as a class decorator
codegen-sh[bot] a44f381
[fix] AttributeError crash when a slice is used as a class decorator
Pierre-Sassoulas dbb411c
Revert "[fix] AttributeError crash when a slice is used as a class deβ¦
Pierre-Sassoulas 4b045f4
Add doc and regression test
Pierre-Sassoulas d27497c
Fix in util
Pierre-Sassoulas 754cfcb
Shortcut the deprecation check for perfs
Pierre-Sassoulas 8be5e62
Better parenthesis
Pierre-Sassoulas d0f2939
Update pylint/checkers/deprecated.py
Pierre-Sassoulas 5b30d91
Further simplification
Pierre-Sassoulas 6f7ab65
Update doc/whatsnew/fragments/10334.bugfix
Pierre-Sassoulas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Using a slice as a class decorator now raise a 'not-callable' message instead of crashing pylint. | ||
|
||
Closes #10334 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
"""Test for slice object used as a decorator.""" | ||
# pylint: disable=too-few-public-methods | ||
s = slice(-2) | ||
@s() # [not-callable] | ||
class A: | ||
"""Class with a slice decorator.""" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
not-callable:4:1:4:4:A:s is not callable:UNDEFINED |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.