Skip to content

Add regression test for false positive invalid-name on attrs class var #10540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add regression test for false positive invalid-name on attrs class var #10540

wants to merge 2 commits into from
+27 −0

Conversation

zenlyj
Copy link
Contributor

@zenlyj zenlyj commented Sep 4, 2025

Type of Changes

Type
✓ 🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Description

Issue should be fixed with pylint-dev/astroid#2811. Mainly adding a regression test here.

Closes #10525

@zenlyj
Copy link
Contributor Author

zenlyj commented Sep 4, 2025 •
edited
Loading

Let me know if I need include a changelog here, there is already one on astroid side so I am unsure if we need one here as well

@zenlyj zenlyj added the Needs astroid update Needs an astroid update (probably a release too) before being mergable label Sep 4, 2025
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 4.0.0, 3.3.9 Sep 4, 2025
Pierre-Sassoulas
Pierre-Sassoulas requested changes Sep 4, 2025
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! pylint is the "front", I think there's a lot less person reading astroid's release note, so it's good to have a changelog in pylint for astroid changes with pylint consequences.

@Pierre-Sassoulas Pierre-Sassoulas added the Blocked 🚧 Blocked by a particular issue label Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Blocked 🚧 Blocked by a particular issue Needs astroid update Needs an astroid update (probably a release too) before being mergable
Projects
None yet
Milestone
3.3.9
Development

Successfully merging this pull request may close these issues.

false positive invalid-name on attrs classvar
2 participants
@zenlyj @Pierre-Sassoulas