Skip to content

Return False instead of raising for .contains with invalid version #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Return False instead of raising for .contains with invalid version #932

wants to merge 2 commits into from

Conversation

Liam-DeVoe
Copy link

Closes #767.

@notatallshaw
Copy link
Member

I'm supportive of this PR because it brings contains inline with filter which already discards invalid versions instead of throwing an error.

You've added tests for Specifier.contains, SpecifierSet.contains, and SpecifierSet.filter, but you are missing tests for Specifier.filter which should be the same ones you added to TestSpecifierSet.test_specifier_filter but for TestSpecifier.test_specifier_filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Permit contains calls to Specifier[Set] to use arbitrary strings
2 participants
@Liam-DeVoe @notatallshaw