Skip to content

fix: set tab indexes explicitly for form #18716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2025
Merged

fix: set tab indexes explicitly for form #18716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df2dced
fix: set tab indexes explicitly for form
miketheman Sep 18, 2025
0801b12
make translations
miketheman Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions warehouse/locale/messages.pot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1140,7 +1140,7 @@ msgid "Sponsors"
msgstr ""

#: warehouse/templates/accounts/login.html:7
#: warehouse/templates/accounts/login.html:87 warehouse/templates/base.html:44
#: warehouse/templates/accounts/login.html:90 warehouse/templates/base.html:44
#: warehouse/templates/base.html:78
msgid "Log in"
msgstr ""
Expand Down Expand Up @@ -1508,7 +1508,7 @@ msgstr ""
msgid "Confirm password to continue"
msgstr ""

#: warehouse/templates/accounts/login.html:56
#: warehouse/templates/accounts/login.html:57
#: warehouse/templates/accounts/register.html:142
#: warehouse/templates/accounts/reset-password.html:28
#: warehouse/templates/manage/manage_base.html:451
Expand All @@ -1517,7 +1517,7 @@ msgid "Password"
msgstr ""

#: warehouse/templates/accounts/login.html:34
#: warehouse/templates/accounts/login.html:58
#: warehouse/templates/accounts/login.html:59
#: warehouse/templates/accounts/recovery-code.html:28
#: warehouse/templates/accounts/register.html:69
#: warehouse/templates/accounts/register.html:91
Expand Down Expand Up @@ -1603,18 +1603,18 @@ msgstr ""
msgid "(required)"
msgstr ""

#: warehouse/templates/accounts/login.html:69
#: warehouse/templates/accounts/login.html:71
#: warehouse/templates/re-auth.html:55
msgid "Your password"
msgstr ""

#: warehouse/templates/accounts/login.html:66
#: warehouse/templates/accounts/login.html:68
#: warehouse/templates/manage/manage_base.html:457
#: warehouse/templates/re-auth.html:82
msgid "Show password"
msgstr ""

#: warehouse/templates/accounts/login.html:91
#: warehouse/templates/accounts/login.html:95
#: warehouse/templates/re-auth.html:86
msgid "Forgot password?"
msgstr ""
Expand Down
8 changes: 6 additions & 2 deletions warehouse/templates/accounts/login.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ <h1 class="page-title">{% trans title=title %}Log in to {{ title }}{% endtrans %
required="required",
class_="form-group__field",
aria_describedby="username-errors",
tabindex="1",
) }}
<div id="username-errors">
{% if form.username.errors %}
Expand All @@ -62,7 +63,8 @@ <h1 class="page-title">{% trans title=title %}Log in to {{ title }}{% endtrans %
<input data-action="change->password#togglePasswords"
data-password-target="showPassword"
id="show-password"
type="checkbox">
type="checkbox"
tabindex="3">
&nbsp;{% trans %}Show password{% endtrans %}
</label>
</div>
Expand All @@ -72,6 +74,7 @@ <h1 class="page-title">{% trans title=title %}Log in to {{ title }}{% endtrans %
autocomplete="current-password",
spellcheck="false", data_password_target="password",
aria_describedby="password-errors",
tabindex="2",
) }}
<div id="password-errors">
{% if form.password.errors %}
Expand All @@ -85,7 +88,8 @@ <h1 class="page-title">{% trans title=title %}Log in to {{ title }}{% endtrans %
<div>
<input type="submit"
value="{% trans %}Log in{% endtrans %}"
class="button button--primary">
class="button button--primary"
tabindex="4">
</div>
<span>
<a href="{{ request.route_url('accounts.request-password-reset') }}">{% trans %}Forgot password?{% endtrans %}</a>
Expand Down