use regular Thread objects for thread execnet model #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do we have any backlogs on why the thread primitives where not used this may be related to the idea of "daemon threads and when they where added to cpython |
|
It's a good point: I tried the test suite with regular threads, but it hung. I needed to switch to demonic ones |
|
3f9e3ca in 2013 removed using the modern primitives for the green apis with the enhancements done in the code recently i believe it absolutely necessary to return to the rich primitives using daemon threads is necessary - but we need to precisely pick when to use them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.