Skip to content

ruff: Addresses issues with ARG #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 15, 2025
Merged

ruff: Addresses issues with ARG #1239

merged 6 commits into from
Aug 15, 2025

Conversation

kingbuzzman
Copy link
Member

No description provided.

@kingbuzzman kingbuzzman requested a review from Copilot August 15, 2025 09:39
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses Ruff linting issues related to the ARG rule by adding # noqa: ARG001 and # noqa: ARG002 comments to suppress warnings about unused function and method arguments. The changes primarily affect test files and some core functionality where arguments are required by interfaces but not used in the implementation.

  • Removes unused imports and function parameters in test files
  • Adds type annotations for better code clarity
  • Suppresses ARG warnings for legitimate unused arguments in fixtures and interface implementations

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/test_initialization.py Removes unused pytest import and monkeypatch parameter
tests/test_fixtures.py Adds ARG suppression comments and type annotations for LiveServer
tests/test_database.py Adds ARG suppression comments for unused fixture parameters
pytest_django_test/db_router.py Adds ARG suppression for unused parameters in router methods
pytest_django_test/app/views.py Adds ARG suppression for unused request parameter
pytest_django/runner.py Adds ARG suppression for unused kwargs parameters
pytest_django/plugin.py Adds ARG suppression for unused parameters
pytest_django/fixtures.py Adds ARG suppression for unused fixture dependencies
pyproject.toml Removes ARG001 and ARG002 from ignore list

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@kingbuzzman kingbuzzman merged commit e495504 into main Aug 15, 2025
21 checks passed
@kingbuzzman kingbuzzman deleted the dev/ruff-rules branch August 15, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant