-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix gh pr new command #13639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix gh pr new command #13639
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be contrib
instead of bugfix
as it's not a bugfix relevant for users of pytest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally to changing the note type, the markup could be improved a little.
Fixed deprecated ``gh pr new`` command in :file:`scripts/prepare-release-pr.py`. | ||
The script now uses ``gh pr create`` which is compatible with GitHub CLI v2.0+. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed deprecated ``gh pr new`` command in :file:`scripts/prepare-release-pr.py`. | |
The script now uses ``gh pr create`` which is compatible with GitHub CLI v2.0+. | |
Fixed deprecated :command:`gh pr new` command in :file:`scripts/prepare-release-pr.py`. | |
The script now uses :command:`gh pr create` which is compatible with GitHub CLI v2.0+. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Furo needs to learn to style them. But markup-wise, they are nice to have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #13638
Description
Fixed deprecated
gh pr new
command inscripts/prepare-release-pr.py
to usegh pr create
instead.Problem
gh pr new
was deprecated in GitHub CLI 2.0 and is no longer a valid commandSolution
gh pr new
withgh pr create
in prepare-release-pr.py (line 133)