Mapped grids #80
Draft
Mapped grids #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #46
Mapped grids can be defined by passing in a
sympyexpression describing the transformation from the physical coordinates to the cartesian grid coordinates. Sympy is then used to calculate the coordinate various metric elements and coordinate transformations required to map the physical quantities to the coordinate quantities (and back).The mapped grids module is used to make a
compressible_mappedsolver (based on Calhoun, D. A., Helzel, C., & LeVeque, R. J. (2008). SIAM review, 50(4), 723-752).I've added documentation and testing for the mapped grids - this will be ready to review once I've added more problems and testing for the
compressible_mappedsolver.