Skip to content

Conversation

belm0
Copy link
Member

@belm0 belm0 commented Nov 1, 2020

partially addresses #719

@codecov
Copy link

codecov bot commented Nov 1, 2020

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.64103%. Comparing base (4f1e3e8) to head (3f1c732).
⚠️ Report is 2840 commits behind head on main.

❌ Your project check has failed because the head coverage (99.64103%) is below the target coverage (100.00000%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main       #1784         +/-   ##
===================================================
+ Coverage   99.64021%   99.64103%   +0.00082%     
===================================================
  Files            114         114                 
  Lines          14453       14486         +33     
  Branches        1105        1106          +1     
===================================================
+ Hits           14401       14434         +33     
  Misses            37          37                 
  Partials          15          15                 
Files with missing lines Coverage Δ
trio/__init__.py 100.00000% <ø> (ø)
trio/_channel.py 100.00000% <100.00000%> (ø)
trio/tests/test_channel.py 100.00000% <100.00000%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pquentin
Copy link
Member

pquentin commented Nov 2, 2020

It looks like codecov was down when you submitted that pull request. Closing/reopening

@pquentin pquentin closed this Nov 2, 2020
@pquentin pquentin reopened this Nov 2, 2020
@pquentin
Copy link
Member

pquentin commented Nov 2, 2020

@belm0 Codecov now complains about aclose() not being tested

@pquentin
Copy link
Member

pquentin commented Nov 2, 2020

3.9.0-rc2 stalled when installing dependencies, closing/reopening...

@pquentin pquentin closed this Nov 2, 2020
@pquentin pquentin reopened this Nov 2, 2020
@belm0
Copy link
Member Author

belm0 commented Nov 6, 2020

@njsmith please take a look

I started with StapledMemoryChannel rather than StapledChannel, since my use case is needing the nowait methods. Not sure whether it's worth making a MemoryChannel abc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants