Skip to content

Emit warning if ping socket select takes longer #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Emit warning if ping socket select takes longer #632

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aef454
Emit warning if ping socket select takes longer
jarus Dec 8, 2020
9ebaf6a
Fixed line length
jarus Dec 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions kazoo/protocol/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,10 +589,17 @@ def _connect_attempt(self, host, hostip, port, retry):
# Ensure our timeout is positive
timeout = max([read_timeout / 2.0 - jitter_time,
jitter_time])
select_start_time = time.time()
s = self.handler.select([self._socket, self._read_sock],
[], [], timeout)[0]

if not s:
select_block_time = time.time() - select_start_time
if select_block_time > read_timeout:
self.logger.warning(
"Socket select took longer than expected: %0.5f",
select_block_time
)
if self.ping_outstanding.is_set():
self.ping_outstanding.clear()
raise ConnectionDropped(
Expand Down