Skip to content

gh-136234: Fix _SelectorSocketTransport.writelines to be robust to connection loss #136743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-136234: Fix _SelectorSocketTransport.writelines to be robust to connection loss #136743

wants to merge 2 commits into from
+25 −0

Conversation

bmerry
Copy link
Contributor

@bmerry bmerry commented Jul 17, 2025 •
edited by bedevere-app bot
Loading

@python-cla-bot
Copy link

The following commit authors need to sign the Contributor License Agreement:

CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Jul 17, 2025
Open
@bmerry
Copy link
Contributor Author

bmerry commented Jul 17, 2025

I've previously signed the CLA on behalf of my organisation, but my work email address has changed since then (same employer though). Is there a process to reuse that form, or do I need to sign a new one? Alternatively, I can rewrite my commits to use that old email address (it still works, just deprecated).

@kumaraditya303
Copy link
Contributor

do I need to sign a new one?

You need to sign again with the new email.

kumaraditya303
kumaraditya303 reviewed Jul 18, 2025
View reviewed changes
Lib/asyncio/selector_events.py Outdated
@@ -1048,6 +1048,11 @@ def _read_ready__on_eof(self):
else:
self.close()

def _write_after_conn_lost(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only used at two places, I would prefer this to be inlined rather than as a new function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done.

@bmerry
Copy link
Contributor Author

bmerry commented Jul 21, 2025

do I need to sign a new one?

You need to sign again with the new email.

Ok, will do. Might take a few days to run it past my employer.

@kumaraditya303 kumaraditya303 added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes type-bug An unexpected behavior, bug, or error labels Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
awaiting review needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes topic-asyncio type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_SelectorSocketTransport.writelines does not protect against connection lost
2 participants
@bmerry @kumaraditya303