gh-136759: Rename lock.h to pylock.h

[aisk]

• Issue: <lock.h> filename is too generic #136759

[colesbury]

Thanks!

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @colesbury for commit f265080 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137041%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

[emmatyping]

I thought it would be good to review OSS code to see if there are any third-party projects that have a file "pylock.h", as we probably don't want to break those projects either. Fortunately I was not able to find anything that obviously conflicts.

Pixar's OpenUSD repository does have a file that is name-equivalent on case-insensitive filesystems like NTFS on Windows: https://github.com/PixarAnimationStudios/OpenUSD/blob/d0d5c33d5655f206a02b58311efa841890fb3894/pxr/base/tf/pyLock.h. However, this file is only included as #include <pxr/base/tf/pyLock.h>, so it shouldn't conflict.

There were no matches on pypi.org data either. I ran the following ClickHouse query against the https://py-code.org data to verify that:

SELECT    
 project_name,
 countIf(distinct project_name, notEquals(extractAll(path, 'pylock\.(h|hh|hpp|c|cc|cpp)'), [])) AS has_pylock
from      pypi
where     skip_reason = ''
group by project_name
order by has_pylock desc;

This came back with every row having 0 count.

[miss-islington-app]

Thanks @aisk for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

[miss-islington-app]

Thanks @aisk for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

[miss-islington-app]

Sorry, @aisk and @kumaraditya303, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ec02db5caa546cb4759999453bd6efc1d517b95c 3.13

[bedevere-app]

GH-137072 is a backport of this pull request to the 3.14 branch.

[aisk]

I'll try to resolve the backport conflict for 3.13.

[bedevere-app]

GH-137075 is a backport of this pull request to the 3.13 branch.