Skip to content

gh-137056: Fix DTrace build support on NetBSD #137057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 6, 2025
Merged

gh-137056: Fix DTrace build support on NetBSD #137057

merged 3 commits into from
Aug 6, 2025

Conversation

furkanonder
Copy link
Contributor

@furkanonder furkanonder commented Jul 23, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jul 23, 2025
Closed
@furkanonder furkanonder added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes build The build process and cross-build OS-netbsd labels Jul 23, 2025
@furkanonder
Copy link
Contributor Author 

╰─$ nm ./python | grep dtrace
0000000000664c22 t $dtrace383._PyGC_Collect
0000000000679f4c t $dtrace395.PyImport_ImportModuleLevelObject
00000000006c8307 t $dtrace443.sys_audit
00000000006c696d t $dtrace443.sys_audit_tstate
0000000000000000 A __dtrace_python___audit
0000000000000000 A __dtrace_python___gc__done
0000000000000000 A __dtrace_python___gc__start
0000000000000000 A __dtrace_python___import__find__load__done
0000000000000000 A __dtrace_python___import__find__load__start
0000000000000000 A __dtraceenabled_python___audit
0000000000000000 A __dtraceenabled_python___gc__done
0000000000000000 A __dtraceenabled_python___gc__start
0000000000000000 A __dtraceenabled_python___import__find__load__done
0000000000000000 A __dtraceenabled_python___import__find__load__start
000000000077b9c5 t dtrace_dof_fini
000000000077bb25 t dtrace_dof_init

serhiy-storchaka
serhiy-storchaka approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka merged commit 54a5fdf into python:main Aug 6, 2025
36 checks passed
@miss-islington-app
Copy link

Thanks @furkanonder for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 6, 2025
@furkanonder @miss-islington
pythongh-137056: Fix DTrace build support on NetBSD (pythonGH-137057)
b5833fe 
(cherry picked from commit 54a5fdf)

Co-authored-by: Furkan Onder <furkanonder@protonmail.com>
@miss-islington-app
Copy link

Sorry, @furkanonder and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 54a5fdffc8e20f111e7a7d2df352e8be057177ff 3.13

@bedevere-app
Copy link

bedevere-app bot commented Aug 6, 2025

GH-137444 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 6, 2025
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Aug 6, 2025
@furkanonder @serhiy-storchaka
[3.13] pythongh-137056: Fix DTrace build support on NetBSD (pythonGH-…
ac6dbce 
…137057)

(cherry picked from commit 54a5fdf)

Co-authored-by: Furkan Onder <furkanonder@protonmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 6, 2025

GH-137445 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 6, 2025
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Aug 6, 2025
@furkanonder @serhiy-storchaka
[3.13] pythongh-137056: Fix DTrace build support on NetBSD (pythonGH-…
754be12 
…137057)

(cherry picked from commit 54a5fdf)

Co-authored-by: Furkan Onder <furkanonder@protonmail.com>
Yhg1s pushed a commit that referenced this pull request Aug 6, 2025
@serhiy-storchaka @furkanonder
[3.13] gh-137056: Fix DTrace build support on NetBSD (GH-137057) (#13…
5c5574b 
…7445)

(cherry picked from commit 54a5fdf)

Co-authored-by: Furkan Onder <furkanonder@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees
No one assigned
Labels
build The build process and cross-build OS-netbsd skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@furkanonder @serhiy-storchaka