Interpret bare ClassVar as inferred, not Any #19573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
I checked the new errors are correct (previously bare |
sterliakov
reviewed
Aug 3, 2025
|
|
||
| class C: | ||
| x: ClassVar = 1 | ||
| y: ClassVar |
There was a problem hiding this comment.
Okay, can we reject at least this in --disallow-any-generics fashion? Doesn't look like something I want to see in typed code silently...
There was a problem hiding this comment.
Yeah, good point. We should reject this with --disallow-any-generics.
|
Diff from mypy_primer, showing the effect of this PR on open source code: sphinx (https://github.com/sphinx-doc/sphinx)
+ sphinx/ext/autodoc/_documenters.py: note: In member "_load_object_by_name" of class "Documenter":
+ sphinx/ext/autodoc/_documenters.py:247:21: error: Argument "objtype" to "_load_object_by_name" has incompatible type "str"; expected "Literal['module', 'class', 'exception', 'function', 'decorator', 'method', 'property', 'attribute', 'data']" [arg-type]
black (https://github.com/psf/black)
+ src/black/trans.py:346:38: error: Variable "black.trans.CustomSplitMapMixin._Key" is not valid as a type [valid-type]
+ src/black/trans.py:346:38: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ src/black/trans.py:351:2: error: Variable "black.trans.CustomSplitMapMixin._Key" is not valid as a type [valid-type]
+ src/black/trans.py:351:2: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
trio (https://github.com/python-trio/trio)
+ src/trio/_tests/test_ssl.py:217: error: Item "None" of "Any | None" has no attribute "SSL_OP_NO_TLSv1_3" [union-attr]
scipy-stubs (https://github.com/scipy/scipy-stubs)
+ scipy-stubs/_lib/_ccallback.pyi:54: error: All protocol members must have explicitly declared types [misc]
+ scipy-stubs/_lib/_ccallback.pyi:55: error: All protocol members must have explicitly declared types [misc]
+ scipy-stubs/_lib/_ccallback.pyi:76: error: All protocol members must have explicitly declared types [misc]
+ scipy-stubs/_lib/_ccallback.pyi:83: error: All protocol members must have explicitly declared types [misc]
+ scipy-stubs/_lib/_ccallback.pyi:84: error: All protocol members must have explicitly declared types [misc]
|
sterliakov
approved these changes
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5587
Apparently, it is part of the spec now. cc @JukkaL