Skip to content

[ROCm] remove hipify work-around that is no longer needed #4705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[ROCm] remove hipify work-around that is no longer needed #4705

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
034c2bb
[ROCm] remove hipify work-around that is no longer needed
jeffdaily Aug 14, 2025
c19b48a
update hipify_torch submodule
jeffdaily Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions fbgemm_gpu/include/fbgemm_gpu/utils/kernel_launcher.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,20 +266,10 @@ struct KernelLauncher {
context.description(),
" CUDA Error: ",
cudaGetErrorString(cuda_error),
#ifdef __HIPCC__
// c10::cuda::get_cuda_error_help has only been recently added to
// Torch HIPify mappings, so wrap with __HIPCC__ until the mapping land
// in PyTorch OSS.
//
// TODO: Remove when HIPify mappings are updated in PyTorch OSS
// c10::hip::get_hip_error_help(cuda_error),
c10::hip::get_hip_check_suffix(),
#else
// TODO: Re-enable when xformers is updated to use a more recent
// version of PyTorch
// c10::cuda::get_cuda_error_help(cuda_error),
c10::cuda::get_cuda_check_suffix(),
#endif
"\n",
c10::cuda::c10_retrieve_device_side_assertion_info());
}
Expand Down
Loading