add back skip CPU containter test when using cuda device #3385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Fiery
pushed a commit
to Fiery/torchrec
that referenced
this pull request
Sep 18, 2025
Summary: as title, missed few tests without skip decorator causing CI CPU unit test to fail, somehow previous diff didn't reveal these ones that actually failed on CI, so adding these back separately. (https://www.internalfb.com/diff/D67302872?dst_version_fbid=815631520895451&transaction_fbid=1481902306176330) Reviewed By: spmex Differential Revision: D82771497
Fiery
force-pushed
the
export-D82771497
branch
from
e2fd67c to
a41cad5
Compare
Fiery
pushed a commit
to Fiery/torchrec
that referenced
this pull request
Sep 18, 2025
Summary: as title, missed few tests without skip decorator causing CI CPU unit test to fail, somehow previous diff didn't reveal these ones that actually failed on CI, so adding these back separately. (https://www.internalfb.com/diff/D67302872?dst_version_fbid=815631520895451&transaction_fbid=1481902306176330) Reviewed By: spmex Differential Revision: D82771497
Fiery
force-pushed
the
export-D82771497
branch
from
a41cad5 to
737da17
Compare
Fiery
force-pushed
the
export-D82771497
branch
from
737da17 to
dfb0de3
Compare
Fiery
pushed a commit
to Fiery/torchrec
that referenced
this pull request
Sep 19, 2025
Summary: as title, missed few tests without skip decorator causing CI CPU unit test to fail, somehow previous diff didn't reveal these ones that actually failed on CI, so adding these back separately. (https://www.internalfb.com/diff/D67302872?dst_version_fbid=815631520895451&transaction_fbid=1481902306176330) Reviewed By: spmex Differential Revision: D82771497
Summary: as title, missed few tests without skip decorator causing CI CPU unit test to fail, somehow previous diff didn't reveal these ones that actually failed on CI, so adding these back separately. (https://www.internalfb.com/diff/D67302872?dst_version_fbid=815631520895451&transaction_fbid=1481902306176330) Reviewed By: spmex Differential Revision: D82771497
Fiery
force-pushed
the
export-D82771497
branch
from
dfb0de3 to
db23f6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
as title, missed few tests without skip decorator causing CI CPU unit test to fail, somehow previous diff didn't reveal these ones that actually failed on CI, so adding these back separately.
(https://www.internalfb.com/diff/D67302872?dst_version_fbid=815631520895451&transaction_fbid=1481902306176330)
Differential Revision: D82771497