set pg names #1986
Merged
set pg names #1986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
This was referenced Nov 4, 2025
tushar00jain
force-pushed
the
pr1986
branch
3 times, most recently
from
2d5ff16 to
135d24c
Compare
tushar00jain
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
tushar00jain
force-pushed
the
pr1986
branch
2 times, most recently
from
e0eca3d to
6b5517c
Compare
fegin
approved these changes
Nov 10, 2025
fegin
requested changes
Nov 10, 2025
Contributor
fegin
left a comment
fegin
left a comment
There was a problem hiding this comment.
Please fix the linter before landing. Also can you confirm that ROCm test failure is not related? I'll re-stamp after the linter fix.
Summary: - we need to pass the global rank information to pytorch so that the pg name can include the pg information - this is necessary to differentiate the default pg's on different replicas - these need to different because flight recorder matches collectives based on pg name as well - add ft training to experiments folder, we'll move remaining pieces of ft to this gradually but make new features only available through this folder
Contributor
Author
|
@fegin fixed linter. the rocm test looks like it's having authentication issue |
fegin
approved these changes
Nov 11, 2025
ahoffman-aws
pushed a commit
to drcanchi-aws/torchtitan
that referenced
this pull request
Nov 11, 2025
Summary: - we need to pass the global rank information to pytorch so that the pg name can include the pg information - this is necessary to differentiate the default pg's on different replicas - these need to different because flight recorder matches collectives based on pg name as well - add ft training to experiments folder, we'll move remaining pieces of ft to this gradually but make new features only available through this folder --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/torchtitan/pull/1986). * pytorch#1988 * pytorch#1987 * __->__ pytorch#1986 Co-authored-by: Tushar Jain <tushar00jain@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Stack created with Sapling. Best reviewed with ReviewStack.