Add AnalogTrajectory and FreqMap #7437
Merged
+471
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size: L
In order to keep using unit-style input, I have hacked the _resolve_parameters_ function a little bit. Assume all inputs should either be tunit value or sympy.Symbol. (I.e. no sympy expression is allowed). I have to add this since we don't have SymbolFunc or ExprFunc in cirq world.
github-actions
bot
added
size: L
BichengYing
requested review from
wcourtney,
vtomole,
verult and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7437 +/- ##
==========================================
- Coverage 98.70% 98.69% -0.01%
==========================================
Files 1114 1119 +5
Lines 98301 98438 +137
==========================================
+ Hits 97024 97156 +132
- Misses 1277 1282 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dstrain115
reviewed
Jun 26, 2025
cirq-google/cirq_google/experimental/analog_experiments/__init__.py
Outdated
Show resolved
Hide resolved
| """Folder for Running Analog experiments.""" | ||
|
|
||
| from cirq_google.experimental.analog_experiments.analog_trajectory_util import ( | ||
| FreqMap as FreqMap, |
There was a problem hiding this comment.
Should this be called FrequencyMap to avoid abbreviations.
cirq-google/cirq_google/experimental/analog_experiments/analog_trajectory_util.py
Outdated
Show resolved
Hide resolved
cirq-google/cirq_google/experimental/analog_experiments/analog_trajectory_util_test.py
Outdated
Show resolved
Hide resolved
|
|
||
| import cirq | ||
| from cirq_google.experimental.analog_experiments import symbol_util as su |
There was a problem hiding this comment.
I am not sure about the dependency graph here. I don't think we want to import experimental from a non-experimental file.
There was a problem hiding this comment.
ParamResolver is under the cirq/study so I move this util file into cirq_google/study. Is that good?
dstrain115
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FreqMap and AnalogTrajectory into cirq_google.experiments.
In this PR, two major differences compared with Trond did before.
AnalogTrajectoryinitialized with classmethod so that the class member is always full_trajectoryFreqMapso that we can provide the symbol into it and plot it with resolver likepulse_plotNew usage example