Make QVM notebooks use development version of cirq_google #7439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: QVM notebooks would use the last stable cirq_google if imported before package upgrade. Solution: Import cirq_google only after its possible upgrade. Fixes b/425769714
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7439 +/- ##
==========================================
- Coverage 98.70% 98.70% -0.01%
==========================================
Files 1119 1119
Lines 98438 98438
==========================================
- Hits 97161 97160 -1
- Misses 1277 1278 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mhucka
requested changes
Jun 26, 2025
docs/hardware/qubit_picking.ipynb
Outdated
| " from cirq_google.engine import load_device_noise_properties as _\n", | ||
| " # raise ImportError when cirq is not new enough\n", | ||
| " if cirq.__version__ == \"1.5.0\":\n", | ||
| " raise ImportError(\"This notebook requires development version of Cirq\")\n", |
There was a problem hiding this comment.
"requires development" → "requires the development".
There was a problem hiding this comment.
done in fa111aa, thanks for flagging this.
mhucka
approved these changes
Jun 27, 2025
ddddddanni
pushed a commit
to ddddddanni/Cirq
that referenced
this pull request
Jul 15, 2025
…#7439) Problem: QVM notebooks would use the last stable cirq_google if imported before package upgrade. Solution: Import cirq_google only after its possible upgrade. Fixes b/425769714
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: QVM notebooks would use the last stable cirq_google
if imported before package upgrade.
Solution: Import cirq_google only after its possible upgrade.
Fixes b/425769714