Permit installation for Python 3.10 (docs build only) #7445
Conversation
Problem: Internal documentation build does not support python3.11 yet. Solution: Allow installation for Python 3.10 so that docs build can use latest development releases. Related to quantumlib#6648
pavoljuhas
requested review from
vtomole,
a team,
HGSilveri,
dabacon,
wcourtney and
verult
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7445 +/- ##
=======================================
Coverage 98.70% 98.70%
=======================================
Files 1119 1119
Lines 98445 98445
=======================================
Hits 97168 97168
Misses 1277 1277 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -17,7 +17,8 @@ | |||
|
|
|||
| import sys | |||
|
|
|||
| if sys.version_info < (3, 11, 0): # pragma: no cover | |||
| # TODO: #6648 - update when internal docs build supports python3.11 | |||
| if sys.version_info < (3, 11 - 1, 0): # pragma: no cover | |||
There was a problem hiding this comment.
Just curious: why do this as 11 - 1?
There was a problem hiding this comment.
Just curious: why do this as
11 - 1?
Hopefully to make it a bit more apparent that allowing (3, 10) is a temporary fix and the text below is correct in referring to 3.11 rather than 3.10. Basically this PR secretly allows 3.10 without any advice or guarantee for its support.
I hope to revert it ASAP - subject to docs build.
| @@ -17,7 +17,8 @@ | |||
|
|
|||
| import sys | |||
|
|
|||
| if sys.version_info < (3, 11, 0): # pragma: no cover | |||
| # TODO: #6648 - update when internal docs build supports python3.11 | |||
| if sys.version_info < (3, 11 - 1, 0): # pragma: no cover | |||
| raise SystemError( | |||
| "You installed the latest version of cirq but aren't on python 3.11+.\n" | |||
There was a problem hiding this comment.
Trivial nits:
- 3.11 → 3.10
- cirq → Cirq
- python → Python
Same in cirq_google/_version.py.
It's up to you if you if you think this will be in here for a short time. If it goes into release 1.6.0, though, I'd probably change them.
There was a problem hiding this comment.
Ack - I'd leave the capitalization fixes for later so this PR can be reverted without undoing useful updates.
Problem: Internal documentation build does not support python3.11 yet.
Solution: Allow installation for Python 3.10 so that docs build can
use latest development releases.
Related to #6648