-
Notifications
You must be signed in to change notification settings - Fork 184
Resolve #851: update references to default branch to use "main" #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This updates references to `master` to be `main`.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
" </td>\n", | ||
" <td>\n", | ||
" <a target=\"_blank\" href=\"https://colab.research.google.com/github/quantumlib/qsim/blob/master/docs/tutorials/q32d14.ipynb\"><img src=\"https://quantumai.google/site-assets/images/buttons/colab_logo_1x.png\" />Run in Google Colab</a>\n", | ||
" <a target=\\"_blank\\" href=\\"https://colab.research.google.com/github/quantumlib/qsim/blob/main/docs/tutorials/q32d14.ipynb\\"><img src=\\"https://quantumai.google/site-assets/images/buttons/colab_logo_1x.png\\" />Run in Google Colab</a>\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JSON syntax is broken here, please fix. As a quick check you can run
jq . docs/tutorials/q32d14.ipynb >/dev/null
to verify the content is parseable.
" </td>\n", | ||
" <td>\n", | ||
" <a target=\"_blank\" href=\"https://colab.research.google.com/github/quantumlib/qsim/blob/master/docs/tutorials/qsimcirq.ipynb\"><img src=\"https://quantumai.google/site-assets/images/buttons/colab_logo_1x.png\" />Run in Google Colab</a>\n", | ||
" <a target=\\"_blank\\" href=\\"https://colab.research.google.com/github/quantumlib/qsim/blob/main/docs/tutorials/qsimcirq.ipynb\\"><img src=\\"https://quantumai.google/site-assets/images/buttons/colab_logo_1x.png\\" />Run in Google Colab</a>\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates to the notebooks broke JSON format. Otherwise LGTM.
This updates references to
master
to bemain
.Note: one of the CI checks is timing out. It may be a transient problem involving some GitHub service. In any case, if we apply PR #901, it should result in completion, so maybe it would be better to apply #901 first.