Skip to content

Conversation

dandragona-dev
Copy link

build_det_orders() is now called within compile_decoder_for_dem() to ensure the right configuration (for the DEM) is being used in each Sinter task. Previously, the TesseractConfig would always be using a single det_orders despite it depending upon the DEM for the task.

  • Feature request for TesseractSinterDecoder requires DEM to be configured correctly #129.
  • Refactored TesseractSinterDecoder constructor to have parameters which are then passed to a TessertConfig during compile_decoder_for_dem().
  • Added test to cover the crash referenced in issues/129.
  • Uses default values from TesseractConfig when applicable, otherwise improvises for num_det_orders, det_order_method, and seed.

@dandragona-dev dandragona-dev force-pushed the sinter-compat-integration branch from 7b32056 to e8dc93e Compare October 7, 2025 15:08
@dandragona-dev dandragona-dev force-pushed the sinter-compat-integration branch from e8dc93e to a686e65 Compare October 7, 2025 15:15
@oscarhiggott oscarhiggott self-requested a review October 17, 2025 19:00
@oscarhiggott
Copy link
Contributor

Thank you, this looks excellent!

I wonder if it might worth including the "tesseract-long-beam" and "tesseract-short-beam" sinter decoders from my issue (#129 ) in the dictionary returned by tesseract_decoder.tesseract_sinter_compat.make_tesseract_sinter_decoders_dict?

@oscarhiggott
Copy link
Contributor

We could also add a small example of how to use Tesseract with sinter in the main Tesseract README.md at the root of the directory (as is done in the chromobius repo, for example). This would make it much easier for new users to get started.

@dandragona-dev
Copy link
Author

Sounds good, I'll add those suggestions in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants