typst: customize light and dark logo at document level #13133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
gordonwoodhull
force-pushed
the
feature/typst-customize-light-dark-alt-logo
branch
2 times, most recently
from
3037271 to
0f9a763
Compare
the main point of this is to delete the final remaining independent implementation of logo resolution and have everything be consistent with the other formats but yeah, also so that you can customize light and dark logos
we did not have any tests for this previously but it did work
gordonwoodhull
force-pushed
the
feature/typst-customize-light-dark-alt-logo
branch
from
0f9a763 to
e2bf972
Compare
and properly extend this to {light,dark} with also optional path
this is kind of silly but this is how typst logo is historically
so if typst logo now takes light, dark then those also have optional path
i guess it's also proof that none of the other formats really need path
this does not extend to enabling dark brand in a typst document
only through the logo. that will fail to resolve a logo and you'll
need to enable dark brand in brand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So you can do
in typst format, to go with
brand-modeand for compatibility with the other formats, which all allow this.One quirk of the Quarto typst format is that you are allowed not to specify the path, so we extend that even to this:
I guess this is kind of silly, but there is a very well-typed function to make the conversion (by adding paths where needed), in case we unexpectedly decide the other formats need this. It would also be possible to extend
resolveBrandto cover whatfillLogoPathsis doing, but the Typescript gets very shaky with an object with all optional fields.More likely, we will deprecate Typst's behavior.
Deletes 12 lines of an independent implementation of logo resolution that I never have to think about again.