Skip to content

Add OpenLayers typings and use to fix type mismatches #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 63 commits into
base: next
Choose a base branch
from

Conversation

maurizi
Copy link

@maurizi maurizi commented Nov 19, 2019

This is a redo of #244, rebased on top of the latest next branch to bring in the changes to support Angular 8 and OpenLayers 6.

I understand if this is adding more type annotations than this project would like to support, but of particular interest to me is getting the imports fixed in the few cases were they were wrong:

I can open a smaller-scope pull request with just those changes if that would be preferred.

davinkevin and others added 30 commits August 1, 2018 16:25
- re-instantiate raster when source change
- add TileEvent(s) on XYZ and OSM
- add wrapX to ArcGISRest
- add example desciption
Neonox31 and others added 11 commits July 23, 2019 08:47
Add distance cluster example.
- angular 8 and openlayer 6
- update all config files (according to angular-cli-diff)
- fix OL breaking change: postrender and prerender
- fix all examples height style
- fix lint errors
- fix `Don't use 'Object' as a type.` according to @type/ol
- remove `on` prefix for all output
- update node in travis CI

BREAKING CHANGES:
- precompose, postcompose become prerender, postrender
- remove `on` prefix for all output, exception for native events :
  - `click` -> `olClick`
  - `select` -> `olFeature`
  - `change` -> `olChange`
@jeremy-eychenne
Copy link
Collaborator

Hi, thank you for your contribution. As we just merged next branch into main, can you please rebase this PR if it is still needed?

If this PR remains unchanged within 3 months, we will automatically close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.