fix well-known URLs in funding.json #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the well-known URLs in the funding.json file by adding proper funding manifest URLs and removing empty wellKnown fields for repository URLs.
- Adds proper
.well-known/funding-manifest-urlsURLs to webpage entries - Removes empty wellKnown fields from repository URL entries
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "webpageUrl": { | ||
| "url": "https://quic-go.net/", | ||
| "wellKnown": "" | ||
| "wellKnown": "https://quic-go.net/.well-known/funding-manifest-urls" |
There was a problem hiding this comment.
[nitpick] The same well-known URL is duplicated across multiple entries. Consider extracting this to a constant or variable to improve maintainability and reduce the risk of inconsistencies.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
How do you even do constants in JSON?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.