-
-
Notifications
You must be signed in to change notification settings - Fork 130
added odd even number check #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for quicksnip ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the contribution, could you add a couple of example uses of your function ?
Take a look at other snippets...
Also as this doesn't use any C++ feature, i think it belongs to the C language instead.
I also just noticed you added a space before the |
Hi @Mathys-Gasnier, Thank you for your feedback and for taking the time to review my contribution! Since the function works for both C and C++, I could either update it with examples, depending on what best aligns with the repository’s goals. I’ll also fix the snippet style issues like the spacing before the : in the metadata. Thank you again for your guidance, and I’ll have the updates ready soon! Best regards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, Thank you for your contribution.
After reviewing your PR, we notice that it doesn't follow our guidelines.
You can find theses guidelines in CONTRIBUTING.md
in the root of the repo.
The odd-even-check.md
file doesn't match the scope of Quicksnip, as you mentioned, It's more of a demonstration than an actual useful snippet.
Please remove function from your PR.
If you have any question or would like to contest this decision please leave a comment in your PR explaining your position.
If no fix is provided within 7-10 days this PR will be closed without further notice
Description
Type of Change
Checklist
Related Issues
Closes #
Additional Context
Screenshots (Optional)
Click to view screenshots