Skip to content

added odd even number check #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Conversation

beast177
Copy link

@beast177 beast177 commented Jan 2, 2025

Description

Type of Change

  • [✅ ] ✨ New snippet
  • 🛠 Improvement to an existing snippet
  • 🐞 Bug fix
  • 📖 Documentation update
  • 🔧 Other (please describe):

Checklist

  • [ ✅] I have tested my code and verified it works as expected.
  • [ ✅] My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Related Issues

Closes #

Additional Context

Screenshots (Optional)

Click to view screenshots

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for quicksnip ready!

Name Link
🔨 Latest commit 7007434
🔍 Latest deploy log https://app.netlify.com/sites/quicksnip/deploys/67776bc95854400008e1f6b4
😎 Deploy Preview https://deploy-preview-125--quicksnip.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the contribution, could you add a couple of example uses of your function ?
Take a look at other snippets...
Also as this doesn't use any C++ feature, i think it belongs to the C language instead.

@Mathys-Gasnier
Copy link
Collaborator

I also just noticed you added a space before the : of some properties, please remove it as it does not follow our snippet style

@beast177
Copy link
Author

beast177 commented Jan 2, 2025

Hey, thanks for the contribution, could you add a couple of example uses of your function ? Take a look at other snippets... Also as this doesn't use any C++ feature, i think it belongs to the C language instead.

Hi @Mathys-Gasnier,

Thank you for your feedback and for taking the time to review my contribution!

Since the function works for both C and C++, I could either update it with examples, depending on what best aligns with the repository’s goals. I’ll also fix the snippet style issues like the spacing before the : in the metadata.

Thank you again for your guidance, and I’ll have the updates ready soon!

Best regards,
Beast177

Copy link
Collaborator

@majvax majvax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, Thank you for your contribution.

After reviewing your PR, we notice that it doesn't follow our guidelines.
You can find theses guidelines in CONTRIBUTING.md in the root of the repo.

The odd-even-check.md file doesn't match the scope of Quicksnip, as you mentioned, It's more of a demonstration than an actual useful snippet.
Please remove function from your PR.

If you have any question or would like to contest this decision please leave a comment in your PR explaining your position.

If no fix is provided within 7-10 days this PR will be closed without further notice

@beast177 beast177 closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants