Improve shard collocation when scheduling #5808
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdettai
force-pushed
the
impr-shard-collocation
branch
from
71727e5 to
4f54d65
Compare
* Add limit of three pipelines per node * Small code simplification
| ordering => return Some(ordering.reverse()), | ||
| } | ||
| // If tie, pick the node with shards already assigned first | ||
| match self.current_num_shards.cmp(&other.current_num_shards) { |
There was a problem hiding this comment.
I think what matters here is whether current_num_shards is non null, no?
fulmicoton-dd
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When placing new shards for an existing source, when affinity is not defined (e.g Kafka source), we currently have no affinity for nodes where we have existing indexing pipelines. This can create a fragmented distribution of shards.
This solution is not perfect, ideally we should split the assignation in two steps (just as we do for the shard affinity):
How was this PR tested?
Added unit test