Skip to content

Fix MinIO configuration to always set region to 'minio' #5823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2025
Merged

Fix MinIO configuration to always set region to 'minio' #5823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/configuration/storage-config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ The Google Cloud Storage flavor (`gcs`) turns off multi-object delete requests a

*MinIO flavor*

The MinIO flavor (`minio`) forces path-style access.
The MinIO flavor (`minio`) overrides the `region` parameter to `minio` and forces path-style access.

Example of a storage configuration for Google Cloud Storage in YAML format:

Expand Down
2 changes: 2 additions & 0 deletions quickwit/quickwit-config/src/storage_config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@ impl S3StorageConfig {
self.disable_multipart_upload = true;
}
Some(StorageBackendFlavor::MinIO) => {
self.region = Some("minio".to_string());
self.force_path_style_access = true;
}
_ => {}
Expand Down Expand Up @@ -497,6 +498,7 @@ mod tests {
assert!(gcs_storage_config.disable_multipart_upload);

let minio_storage_config = storage_configs[3].as_s3().unwrap();
assert_eq!(minio_storage_config.region, Some("minio".to_string()));
assert!(minio_storage_config.force_path_style_access);
}

Expand Down