Update tantivy version #5863
Open
Update tantivy version #5863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In quickwit-oss/tantivy#2679 we modified the prototype of the function that expose fields information. The new method expose the size used per field for each tantivy datastructure. This PR updates quickwit to: - compile - limit the number of fields exported in the packager to the 1k most prominent fields. This is also a preliminary solution to address #5832
PSeitz-dd
reviewed
Aug 14, 2025
| let num_fields = fields_metadata.len(); | ||
|
|
||
| let max_packaged_field_caps = | ||
| quickwit_common::get_from_env(QW_MAX_PACKAGED_FIELDS_CAPS_ENV_KEY, 1_000); |
There was a problem hiding this comment.
Suggested change
| quickwit_common::get_from_env(QW_MAX_PACKAGED_FIELDS_CAPS_ENV_KEY, 1_000); | |
| quickwit_common::get_from_env(QW_MAX_PACKAGED_FIELDS_CAPS_ENV_KEY, QW_MAX_PACKAGED_FIELDS_CAPS_ENV_DEFAULT); |
PSeitz-dd
reviewed
Aug 14, 2025
| use tokio::runtime::Handle; | ||
| use tracing::{debug, info, instrument, warn}; | ||
|
|
||
| const LIMIT_PACKAGED_FIELDS: usize = 1_000; |
There was a problem hiding this comment.
Suggested change
| const LIMIT_PACKAGED_FIELDS: usize = 1_000; | |
| const QW_MAX_PACKAGED_FIELDS_CAPS_ENV_DEFAULT: usize = 1_000; |
PSeitz-dd
reviewed
Aug 14, 2025
| ); | ||
| fields_metadata | ||
| .into_iter() | ||
| .k_largest_by_key(LIMIT_PACKAGED_FIELDS, total_num_bytes) |
There was a problem hiding this comment.
Suggested change
| .k_largest_by_key(LIMIT_PACKAGED_FIELDS, total_num_bytes) | |
| .k_largest_by_key(max_packaged_field_caps, total_num_bytes) |
PSeitz-dd
reviewed
Aug 14, 2025
| @@ -268,6 +272,41 @@ fn try_extract_terms( | |||
| Ok(terms) | |||
| } | |||
|
|
|||
| fn total_num_bytes(field_metadata: &FieldMetadata) -> u64 { | |||
There was a problem hiding this comment.
list fields also returns dynamic fields in a JSON field. How does total_num_bytes work with that? Does it return 0 or the size of the parent field?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In quickwit-oss/tantivy#2679 we modified the prototype of the function that expose fields information.
The new method expose the size used per field for each tantivy datastructure.
This PR updates quickwit to:
This is also a preliminary solution to address
#5832